utils/checkpackagelib: really check variable name

Currently, when a package defines an unprefixed variable, but its value
contains a properly prefixed expansion (or even just the name of a
variable), there is not error reported (e.g. with the recently fixed
composer issue):

    BASE_SITE = https://getcomposer.org/download/$(COMPOSER_VERSION)/composer.phar

The reason is that he check is done on the whole line, rather than on
the variable that is being set.

We fix that by really looking at the variable we found, instead of
looking in the whole line.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Ricardo Martincoski <ricardo.martincoski@datacom.com.br>
Signed-off-by: Arnout Vandecappelle <arnout@mind.be>
This commit is contained in:
Yann E. MORIN
2024-06-07 15:48:47 +02:00
committed by Arnout Vandecappelle
parent 322e8d8451
commit b0964df557

View File

@@ -316,7 +316,7 @@ class TypoInPackageVariable(_CheckFunction):
if self.ALLOWED.match(variable):
return
if self.REGEX.search(text) is None:
if self.REGEX.search(variable) is None:
return ["{}:{}: possible typo: {} -> *{}*"
.format(self.filename, lineno, variable, self.package),
text]