29d6f319a0
When a SysV init script is inside package/ it doesn't need to be executable. However, when an init script is inside a fs_overlay, it *does* need to be executable. Therefore, skip the NotExecutable test for init scripts. We detect them based on the directory /etc/init.d Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> [Arnout: update .checkpackageignore] Signed-off-by: Arnout Vandecappelle <arnout@mind.be>
30 lines
996 B
Python
30 lines
996 B
Python
import os
|
|
import subprocess
|
|
from checkpackagelib.base import _Tool
|
|
|
|
|
|
class NotExecutable(_Tool):
|
|
def ignore(self):
|
|
return False
|
|
|
|
def run(self):
|
|
if self.ignore():
|
|
return
|
|
if os.access(self.filename, os.X_OK):
|
|
return ["{}:0: This file does not need to be executable{}".format(self.filename, self.hint())]
|
|
|
|
|
|
class Shellcheck(_Tool):
|
|
def run(self):
|
|
cmd = ['shellcheck', self.filename]
|
|
try:
|
|
p = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
|
|
stdout = p.communicate()[0]
|
|
processed_output = [str(line.decode().rstrip()) for line in stdout.splitlines() if line]
|
|
if p.returncode == 0:
|
|
return
|
|
return ["{}:0: run 'shellcheck' and fix the warnings".format(self.filename),
|
|
'\n'.join(processed_output)]
|
|
except FileNotFoundError:
|
|
return ["{}:0: failed to call 'shellcheck'".format(self.filename)]
|