On autobuilder config with BR2_TOOLCHAIN_HAS_THREADS not set the following error happens when building the pthreadpool package: ``` -- Looking for pthread_create in pthreads -- Looking for pthread_create in pthreads - not found -- Looking for pthread_create in pthread -- Looking for pthread_create in pthread - not found -- Check if compiler accepts -pthread -- Check if compiler accepts -pthread - no CMake Error at /home/buildroot/instance-0/output-1/host/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message): Could NOT find Threads (missing: Threads_FOUND) Call Stack (most recent call first): /home/buildroot/instance-0/output-1/host/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE) /home/buildroot/instance-0/output-1/host/share/cmake-3.31/Modules/FindThreads.cmake:226 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) CMakeLists.txt:143 (FIND_PACKAGE) -- Configuring incomplete, errors occurred! ``` This can be reproduced with: ``` cat >.config <<EOF BR2_armeb=y BR2_TOOLCHAIN_BUILDROOT_UCLIBC=y BR2_PTHREADS_NONE=y BR2_PACKAGE_PTHREADPOOL=y EOF make olddefconfig make pthreadpool ``` Since the introduction of this package in [1], the dependency was not included. Since this package was part of the tensorflow-lite dependencies that required thread it was not an issue. This patch adds BR2_TOOLCHAIN_HAS_THREADS in the dependency to avoid errors when built as a standalone package. [1]f2486a6cf9package/pthreadpool: new package Fixes: https://autobuild.buildroot.org/results/35a/35aa100d72c6875350ad10c57f028f04052cbf79 Signed-off-by: Thomas Perale <thomas.perale@mind.be> Signed-off-by: Romain Naour <romain.naour@smile.fr> (cherry picked from commit627af87bda) Signed-off-by: Thomas Perale <thomas.perale@mind.be>
13 lines
335 B
Plaintext
13 lines
335 B
Plaintext
config BR2_PACKAGE_PTHREADPOOL
|
|
bool "pthreadpool"
|
|
depends on BR2_TOOLCHAIN_HAS_THREADS
|
|
select BR2_PACKAGE_FXDIV
|
|
help
|
|
Pthreadpool is a portable and efficient thread pool
|
|
implementation.
|
|
|
|
https://github.com/Maratyszcza/pthreadpool
|
|
|
|
comment "pthreadpool needs a toolchain w/ threads"
|
|
depends on !BR2_TOOLCHAIN_HAS_THREADS
|